#209 Fix checkboxes on search screen and use correct status on ticket table

inc/print_tickets.inc.php

@@ -118,17 +118,16 @@ $possible_status = array();
 $results = hesk_dbQuery($statusSql);
 while ($row = $results->fetch_assoc())
 {
-    array_push($possible_status, $row['ID']);
+    $possible_status[$row['ID']] = $row['ID'];
     $totalStatuses++;
 }
 $status = $possible_status;
-
 // Process statuses unless overridden with "s_all" variable
 if ( ! hesk_GET('s_all') )
 {
     foreach ($status as $k => $v)
     {
-        if (empty($_GET['s' . $k]))
+        if (empty($_GET['s' . $v]))
         {
             unset($status[$k]);
         }

inc/show_search_form.inc.php

@@ -132,7 +132,7 @@ $more2 = empty($_GET['more2']) ? 0 : 1;
                                     <?php
                                     $rowCounter = 1;
                                     $statusRS = hesk_dbQuery('SELECT `ID`, `TextColor` FROM `'.hesk_dbEscape($hesk_settings['db_pfix']).'statuses`');
-                                    while ($row = $statusRS->fetch_assoc())
+                                    while ($row = hesk_dbFetchAssoc($statusRS))
                                     {
                                         if ($rowCounter > 3)
                                         {

inc/ticket_list.inc.php

@@ -404,8 +404,9 @@ if ($total > 0)
         // Print ticket status
         if ( hesk_show_column('status') )
         {
-            $statusName = hesk_dbFetchAssoc(hesk_dbQuery("SELECT `Key`, `TextColor` FROM `".hesk_dbEscape($hesk_settings['db_pfix'])."statuses` WHERE ID = ".$ticket['status']));
-            $ticket['status']='<span style="color: '.$statusName['TextColor'].'">'.$hesklang[$statusName['Key']].'</span>';
+            $statusRS = hesk_dbQuery("SELECT `ID`, `TextColor` FROM `".hesk_dbEscape($hesk_settings['db_pfix'])."statuses` WHERE ID = ".$ticket['status']);
+            $statusName = hesk_dbFetchAssoc($statusRS);
+            $ticket['status']='<span style="color: '.$statusName['TextColor'].'">'.mfh_getDisplayTextForStatusId($statusName['ID']).'</span>';
             echo '<td class="'.$color.'">'.$ticket['status'].'&nbsp;</td>';
         }