Merge e96fddffcb into 5f3a67dae2

src/js/simplemde.js

@@ -333,7 +333,7 @@ function toggleSideBySide(editor) {
 	var wrapper = cm.getWrapperElement();
 	var preview = wrapper.nextSibling;
 	var toolbarButton = editor.toolbarElements["side-by-side"];
-
+	var toggleOn = false;
 	if(/editor-preview-active-side/.test(preview.className)) {
 		preview.className = preview.className.replace(
 			/\s*editor-preview-active-side\s*/g, ""
@@ -351,6 +351,7 @@ function toggleSideBySide(editor) {
 		}, 1);
 		toolbarButton.className += " active";
 		wrapper.className += " CodeMirror-sided";
+		toggleOn = true;
 	}
 
 	// Hide normal preview if active
@@ -365,13 +366,21 @@ function toggleSideBySide(editor) {
 		toolbar_div.className = toolbar_div.className.replace(/\s*disabled-for-preview*/g, "");
 	}
 
-	// Start preview with the current text
-	preview.innerHTML = editor.options.previewRender(editor.value(), preview);
+	var renderfunc = function() {
+		preview.innerHTML = editor.options.previewRender(editor.value(), preview);
+	};
 
-	// Updates preview
-	cm.on("update", function() {
+	//register the function it to cm object it can be reffered by next toggle.
+	if(!cm.renderfunc) {
+		cm.renderfunc = renderfunc;
+	}
+	//if toggle off should remove the old listener avoid register a new listener each click 'toggleSideBySide' button
+	if(toggleOn) {
 		preview.innerHTML = editor.options.previewRender(editor.value(), preview);
-	});
+		cm.on("update", cm.renderfunc);
+	} else {
+		cm.off("update", cm.renderfunc);
+	}
 }