From 0dc4c2697ea39e459cd41c3703f42b7fe11744aa Mon Sep 17 00:00:00 2001 From: Situphen Date: Mon, 20 Jan 2020 17:35:17 +0100 Subject: [PATCH 1/2] Differentiate between regular autosave delay and submit autosave delay --- CHANGELOG.md | 5 ++++- README.md | 2 ++ src/js/easymde.js | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b19580..4e055b3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,10 @@ All notable changes to easymde will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). - +## [Unreleased] +### Changed +- Delay before assuming that submit of the form as failed is `autosave.submit_delay` instead of `autosave.delay` ([#139]). + ## [2.9.0] - 2020-01-13 ### Added - Missing minHeight option in type definition (Thanks to [@t49tran], [#123]). diff --git a/README.md b/README.md index 00e3be3..97f1c3b 100644 --- a/README.md +++ b/README.md @@ -120,6 +120,7 @@ easyMDE.value('New input for **EasyMDE**'); - **autosave**: *Saves the text that's being written and will load it back in the future. It will forget the text when the form it's contained in is submitted.* - **enabled**: If set to `true`, saves the text automatically. Defaults to `false`. - **delay**: Delay between saves, in milliseconds. Defaults to `10000` (10s). + - **submit_delay**: Delay before assuming that submit of the form failed and saving the text, in milliseconds. Defaults to `10000` (10s). - **uniqueId**: You must set a unique string identifier so that EasyMDE can autosave. Something that separates this from other instances of EasyMDE elsewhere on your website. - **blockStyles**: Customize how certain buttons that style blocks of text behave. - **bold**: Can be set to `**` or `__`. Defaults to `**`. @@ -201,6 +202,7 @@ var editor = new EasyMDE({ enabled: true, uniqueId: "MyUniqueID", delay: 1000, + submit_delay: 5000, }, blockStyles: { bold: "__", diff --git a/src/js/easymde.js b/src/js/easymde.js index 0a73bdd..ed980ea 100644 --- a/src/js/easymde.js +++ b/src/js/easymde.js @@ -1929,7 +1929,7 @@ EasyMDE.prototype.autosave = function () { // Restart autosaving in case the submit will be cancelled down the line setTimeout(function () { easyMDE.autosave(); - }, easyMDE.options.autosave.delay || 10000); + }, easyMDE.options.autosave.submit_delay || 10000); }); } From b4eca2a3d64fc667a3e7a584ecf329238f1e3e51 Mon Sep 17 00:00:00 2001 From: Jeroen Akkerman Date: Sat, 25 Jan 2020 23:35:11 +0100 Subject: [PATCH 2/2] Add name to changelog and add non-breaking option --- CHANGELOG.md | 2 +- README.md | 2 +- src/js/easymde.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4e055b3..afea2c9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### Changed -- Delay before assuming that submit of the form as failed is `autosave.submit_delay` instead of `autosave.delay` ([#139]). +- Delay before assuming that submit of the form as failed is `autosave.submit_delay` instead of `autosave.delay` (Thanks to [@Situphen], [#139]). ## [2.9.0] - 2020-01-13 ### Added diff --git a/README.md b/README.md index 97f1c3b..4911ff1 100644 --- a/README.md +++ b/README.md @@ -120,7 +120,7 @@ easyMDE.value('New input for **EasyMDE**'); - **autosave**: *Saves the text that's being written and will load it back in the future. It will forget the text when the form it's contained in is submitted.* - **enabled**: If set to `true`, saves the text automatically. Defaults to `false`. - **delay**: Delay between saves, in milliseconds. Defaults to `10000` (10s). - - **submit_delay**: Delay before assuming that submit of the form failed and saving the text, in milliseconds. Defaults to `10000` (10s). + - **submit_delay**: Delay before assuming that submit of the form failed and saving the text, in milliseconds. Defaults to `autosave.delay` or `10000` (10s). - **uniqueId**: You must set a unique string identifier so that EasyMDE can autosave. Something that separates this from other instances of EasyMDE elsewhere on your website. - **blockStyles**: Customize how certain buttons that style blocks of text behave. - **bold**: Can be set to `**` or `__`. Defaults to `**`. diff --git a/src/js/easymde.js b/src/js/easymde.js index ed980ea..e3ea9d6 100644 --- a/src/js/easymde.js +++ b/src/js/easymde.js @@ -1929,7 +1929,7 @@ EasyMDE.prototype.autosave = function () { // Restart autosaving in case the submit will be cancelled down the line setTimeout(function () { easyMDE.autosave(); - }, easyMDE.options.autosave.submit_delay || 10000); + }, easyMDE.options.autosave.submit_delay || easyMDE.options.autosave.delay || 10000); }); }