Add option to enable the app only for users in a specific group (#135)
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>master
padre
418b5aceaf
commit
9bf62db3aa
@ -0,0 +1,65 @@
|
||||
<?php
|
||||
/**
|
||||
* @copyright Copyright (c) 2017 Lukas Reschke <lukas@statuscode.ch>
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
namespace OCA\Richdocuments;
|
||||
|
||||
use OCP\IConfig;
|
||||
use OCP\IGroupManager;
|
||||
use OCP\IUser;
|
||||
|
||||
class PermissionManager {
|
||||
const APP_ID = 'richdocuments';
|
||||
/** @var IConfig */
|
||||
private $config;
|
||||
/** @var IGroupManager */
|
||||
private $groupManager;
|
||||
|
||||
public function __construct(IConfig $config,
|
||||
IGroupManager $groupManager) {
|
||||
$this->config = $config;
|
||||
$this->groupManager = $groupManager;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $groupString
|
||||
* @return array
|
||||
*/
|
||||
private function splitGroups($groupString) {
|
||||
return explode('|', $groupString);
|
||||
}
|
||||
|
||||
public function isEnabledForUser(IUser $user) {
|
||||
$enabledForGroups = $this->config->getAppValue(self::APP_ID, 'use_groups', '');
|
||||
if($enabledForGroups === '') {
|
||||
return true;
|
||||
}
|
||||
|
||||
$groups = $this->splitGroups($enabledForGroups);
|
||||
$uid = $user->getUID();
|
||||
foreach($groups as $group) {
|
||||
if($this->groupManager->isInGroup($uid, $group)) {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
}
|
@ -0,0 +1,118 @@
|
||||
<?php
|
||||
/**
|
||||
* @copyright Copyright (c) 2017 Lukas Reschke <lukas@statuscode.ch>
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
namespace Tests\Richdocuments;
|
||||
|
||||
use OCA\Richdocuments\PermissionManager;
|
||||
use OCP\IConfig;
|
||||
use OCP\IGroupManager;
|
||||
use OCP\IUser;
|
||||
use Test\TestCase;
|
||||
|
||||
class PermissionManagerTest extends TestCase {
|
||||
/** @var IConfig|\PHPUnit_Framework_MockObject_MockBuilder */
|
||||
private $config;
|
||||
/** @var IGroupManager|\PHPUnit_Framework_MockObject_MockBuilder */
|
||||
private $groupManager;
|
||||
/** @var PermissionManager */
|
||||
private $permissionManager;
|
||||
|
||||
public function setUp() {
|
||||
parent::setUp();
|
||||
$this->config = $this->createMock(IConfig::class);
|
||||
$this->groupManager = $this->createMock(IGroupManager::class);
|
||||
$this->permissionManager = new PermissionManager($this->config, $this->groupManager);
|
||||
}
|
||||
|
||||
public function testIsEnabledForUserEnabledNoRestrictions() {
|
||||
/** @var IUser|\PHPUnit_Framework_MockObject_MockBuilder $user */
|
||||
$user = $this->createMock(IUser::class);
|
||||
|
||||
$this->config
|
||||
->expects($this->once())
|
||||
->method('getAppValue')
|
||||
->with('richdocuments', 'use_groups', '')
|
||||
->willReturn('');
|
||||
|
||||
$this->assertTrue($this->permissionManager->isEnabledForUser($user));
|
||||
}
|
||||
|
||||
public function testIsEnabledForUserEnabledNotInGroup() {
|
||||
/** @var IUser|\PHPUnit_Framework_MockObject_MockBuilder $user */
|
||||
$user = $this->createMock(IUser::class);
|
||||
$user
|
||||
->expects($this->once())
|
||||
->method('getUID')
|
||||
->willReturn('TestUser');
|
||||
|
||||
$this->config
|
||||
->expects($this->once())
|
||||
->method('getAppValue')
|
||||
->with('richdocuments', 'use_groups', '')
|
||||
->willReturn('Enabled1|Enabled2|Enabled3');
|
||||
|
||||
$this->groupManager
|
||||
->expects($this->at(0))
|
||||
->method('isInGroup')
|
||||
->with('TestUser', 'Enabled1')
|
||||
->willReturn(false);
|
||||
$this->groupManager
|
||||
->expects($this->at(1))
|
||||
->method('isInGroup')
|
||||
->with('TestUser', 'Enabled2')
|
||||
->willReturn(false);
|
||||
$this->groupManager
|
||||
->expects($this->at(2))
|
||||
->method('isInGroup')
|
||||
->with('TestUser', 'Enabled3')
|
||||
->willReturn(false);
|
||||
|
||||
$this->assertFalse($this->permissionManager->isEnabledForUser($user));
|
||||
}
|
||||
|
||||
public function testIsEnabledForUserEnabledInGroup() {
|
||||
/** @var IUser|\PHPUnit_Framework_MockObject_MockBuilder $user */
|
||||
$user = $this->createMock(IUser::class);
|
||||
$user
|
||||
->expects($this->once())
|
||||
->method('getUID')
|
||||
->willReturn('TestUser');
|
||||
|
||||
$this->config
|
||||
->expects($this->once())
|
||||
->method('getAppValue')
|
||||
->with('richdocuments', 'use_groups', '')
|
||||
->willReturn('Enabled1|Enabled2|Enabled3');
|
||||
|
||||
$this->groupManager
|
||||
->expects($this->at(0))
|
||||
->method('isInGroup')
|
||||
->with('TestUser', 'Enabled1')
|
||||
->willReturn(false);
|
||||
$this->groupManager
|
||||
->expects($this->at(1))
|
||||
->method('isInGroup')
|
||||
->with('TestUser', 'Enabled2')
|
||||
->willReturn(true);
|
||||
|
||||
$this->assertTrue($this->permissionManager->isEnabledForUser($user));
|
||||
}
|
||||
}
|
Cargando…
Referencia en una nueva incidencia