From 3bc6a6f357cf131f4f8933c9e20f6d2fe02bfd5e Mon Sep 17 00:00:00 2001 From: Skylar Ittner Date: Sun, 19 Nov 2017 01:27:43 -0700 Subject: [PATCH] Make UI consistent with other Apps --- lang/en_us.php | 1 + pages/edittask.php | 130 +++++++++++++++++++++++++-------------------- pages/home.php | 30 ++++++++--- pages/messages.php | 3 -- pages/mytasks.php | 1 - pages/taskman.php | 5 +- 6 files changed, 100 insertions(+), 70 deletions(-) diff --git a/lang/en_us.php b/lang/en_us.php index 472dd20..f5f04ab 100644 --- a/lang/en_us.php +++ b/lang/en_us.php @@ -75,4 +75,5 @@ define("STRINGS", [ "task deleted" => "Task deleted.", "finished on" => "Finished on: {date}", "started on" => "Started on: {date}", + "add task" => "Add Task" ]); \ No newline at end of file diff --git a/pages/edittask.php b/pages/edittask.php index 16467df..2389f9e 100644 --- a/pages/edittask.php +++ b/pages/edittask.php @@ -3,65 +3,81 @@ require_once __DIR__ . '/../required.php'; redirectifnotloggedin(); ?> -

- +
+

+ +

+
-if (!is_empty($VARS['taskid'])) { - $taskid = $VARS['taskid']; + has('tasks', [ - '[>]assigned_tasks' => [ - 'taskid' => 'taskid' - ] - ], [ - "AND" => [ - "OR" => [ - 'tasks.taskcreatoruid' => $_SESSION['uid'], - 'assigned_tasks.userid' => $managed_uids - ], - "tasks.taskid" => $taskid - ]]); + if (!is_empty($VARS['taskid'])) { + $taskid = $VARS['taskid']; + + $managed_uids = getManagedUIDs($_SESSION['uid']); + // There needs to be at least one entry otherwise the SQL query craps itself + if (count($managed_uids) < 1) { + $managed_uids = [-1]; + } + $allowed = $database->has('tasks', [ + '[>]assigned_tasks' => [ + 'taskid' => 'taskid' + ] + ], [ + "AND" => [ + "OR" => [ + 'tasks.taskcreatoruid' => $_SESSION['uid'], + 'assigned_tasks.userid' => $managed_uids + ], + "tasks.taskid" => $taskid + ]]); - if (!$allowed) { - header("Location: app.php?page=edittask&msg=task_edit_not_allowed"); - die(lang("task edit not allowed", false)); + if (!$allowed) { + header("Location: app.php?page=edittask&msg=task_edit_not_allowed"); + die(lang("task edit not allowed", false)); + } } -} -if (!is_empty($taskid)) { - $task = $database->select('tasks', '*', ['taskid' => $taskid])[0]; -} -if (!is_empty($taskid) && $database->has('assigned_tasks', ['taskid' => $taskid])) { - $tass = $database->select('assigned_tasks', '*', ['taskid' => $taskid])[0]; -} else { - $tass['userid'] = null; -} -?> -
- - - - - : " required="required" class="form-control" value=""/> -
- :
- -
- : - " placeholder="" /> -
- : " /> - -
- : "/> -
- - -
+ if (!is_empty($taskid)) { + $task = $database->select('tasks', '*', ['taskid' => $taskid])[0]; + } + if (!is_empty($taskid) && $database->has('assigned_tasks', ['taskid' => $taskid])) { + $tass = $database->select('assigned_tasks', '*', ['taskid' => $taskid])[0]; + } else { + $tass['userid'] = null; + } + ?> +
+
+ + + + + : " required="required" class="form-control" value=""/> +
+ :
+ +
+ : + " placeholder="" /> +
+ : " /> + +
+ : "/> +
+ +
+ diff --git a/pages/home.php b/pages/home.php index b822b60..06dd7eb 100644 --- a/pages/home.php +++ b/pages/home.php @@ -5,13 +5,31 @@ redirectifnotloggedin(); ?>
- +
+
+

+ +

+
+
+ +
+
- +
+
+

+ +

+
+
+ +
+
\ No newline at end of file diff --git a/pages/messages.php b/pages/messages.php index f32d2b5..b66dd68 100644 --- a/pages/messages.php +++ b/pages/messages.php @@ -3,9 +3,6 @@ require_once __DIR__ . '/../required.php'; redirectifnotloggedin(); ?> -
diff --git a/pages/mytasks.php b/pages/mytasks.php index b0962a9..05ba245 100644 --- a/pages/mytasks.php +++ b/pages/mytasks.php @@ -3,7 +3,6 @@ require_once __DIR__ . '/../required.php'; redirectifnotloggedin(); ?> -
-

-
- +
+