From e6be90a8eb1fef487fa41b511c20b20babc71e54 Mon Sep 17 00:00:00 2001
From: Skylar Ittner <admin@netsyms.com>
Date: Mon, 10 Sep 2018 19:42:53 -0600
Subject: [PATCH] Use select dropdown for users when less than 30 to pick from

---
 pages/permissions.php    | 39 +++++++++++++++++++++++++++++++++------
 static/js/permissions.js |  4 +++-
 2 files changed, 36 insertions(+), 7 deletions(-)

diff --git a/pages/permissions.php b/pages/permissions.php
index cafcf93..f1d80ab 100644
--- a/pages/permissions.php
+++ b/pages/permissions.php
@@ -30,13 +30,40 @@ if ($VARS['user'] && $database->has('accounts', ['username' => $VARS['user']]))
                     <div class="form-group">
                         <label for="user-box"><i class="fas fa-id-card"></i> <?php lang("user"); ?></label><br />
                         <div class="input-group">
-                            <input type="text"<?php if ($permissions === false) { ?>id="user-box"<?php } ?> class="form-control" value="<?php echo $user ?>" name="user" placeholder="<?php lang("type to select a user"); ?>" <?php
-                            if ($permissions !== false) {
-                                echo "readonly";
+                            <?php
+                            if ($database->count('accounts', ['deleted[!]' => 1]) > 30) {
+                                ?>
+                                <input type="text"<?php if ($permissions === false) { ?>id="user-box"<?php } ?> class="form-control" value="<?php echo $user ?>" name="user" placeholder="<?php lang("type to select a user"); ?>" <?php
+                                if ($permissions !== false) {
+                                    echo "readonly";
+                                }
+                                ?>/>
+                                       <?php
+                                   } else {
+                                       if ($permissions === false) {
+                                           ?>
+                                    <select id="user-box" class="form-control" name="user">
+                                        <option value=""><?php lang("Choose a user") ?></option>
+                                        <?php
+                                        $allusers = $database->select('accounts', ['username', 'realname'], ['deleted[!]' => 1, 'ORDER' => ['realname' => 'ASC']]);
+                                        foreach ($allusers as $u) {
+                                            echo "<option value=\"$u[username]\">$u[realname] ($u[username])</option>\n";
+                                        }
+                                        ?>
+                                    </select>
+                                    <?php
+                                } else {
+                                    $realname = $database->get('accounts', 'realname', ['username' => $user]);
+                                    ?>
+                                    <input type="text" class="form-control" value="<?php echo "$realname ($user)" ?>" readonly disabled />
+                                    <input type="hidden" name="user" value="<?php echo $user ?>" />
+                                    <?php
+                                }
                             }
-                            ?>/>
-                            <div class="input-group-append">
-                                <?php if ($permissions === false) { ?>
+                            ?>
+                            <div class = "input-group-append">
+                                <?php if ($permissions === false) {
+                                    ?>
                                     <button class="btn btn-default" type="button" id="selectuserbtn"><i class="fa fa-chevron-right"></i> <?php lang("next") ?></button>
                                 <?php } ?>
                             </div>
diff --git a/static/js/permissions.js b/static/js/permissions.js
index 57a9735..509493f 100644
--- a/static/js/permissions.js
+++ b/static/js/permissions.js
@@ -83,7 +83,9 @@ var options = {
     cssClasses: "form-control form-control-sm"
 };
 
-$("#user-box").easyAutocomplete(options);
+if ($("#user-box").get(0).tagName != "SELECT") {
+    $("#user-box").easyAutocomplete(options);
+}
 
 $("#user-box").keyup(function (e) {
     if (e.keyCode == 13) {